I think jorvik had a fair chunk of an update in the last 12 months so maybe take a look on trip advisor/Google etc for some up to date info. Could have made it the best thing since sliced bread or completely ruined it for all i know.
York dungeon is like every other “dungeon” museum, not for squeamish kids and unless they really like that sort of thing not worth the visit if they’ve been to another one. If they’re not squeamish and haven’t seen it all before though it might be just what you’re after.
Additional/alternative s:
I always enjoyed what’s now the Yorkshire museum, chocolate experience is also a good call. I’ve also heard good things about dig.
Much (not walking any how) further out is the air museum at elvington if that’s their thing.
The cold war bunker is well worth a visit but i can’t imagine being a bit with kids.