The front one looks ok, but if that is aluminium or similar It’s very bad idea to have those rough edges on it.
The rear one looks less good, too high and too long.
A few post back you posed the question:
Question. So. Does it matter where you position a mudguard as long as its effective.
Yes, if it could be more effective positioned elsewhere. It needs to much closer to the tyre, At the moment it’s only keeping a small strip down the centre of your back un splattered, a sort of reverse Pepé Le Pew effect
[edit]
Just spotted the gear cables too. Not good, you want to route the cables so that they take the shortest smoothest line. you’ve added two tight bends where one wider curve would have been better.