pffft! Here’s my opinion, take it as you will.
If we forget singlespeed/fixed bikes for the time being….
Crank length on the road for a mere mortal makes very little difference. You can spin faster with shorter cranks and crank harder with longer cranks but for most of us, the gears take up the difference.
Offroad the same applies but longer cranks are prone to hitting trailside objects like rocks and tussocks. If your bike has a low BB then long cranks would be a bad idea, assuming you ride in places with lots of high things but ultimately it comes down to your height and riding style.
But at the end of the day if you’re a normal person who just rides for fun, it’s not going to make much difference at all. From experience I’d say 170 is the best of both worlds, 185 seems a bit long and should only be for people with inordinately long or weak legs.